lidavidm commented on a change in pull request #11023:
URL: https://github.com/apache/arrow/pull/11023#discussion_r741054324
##########
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic_test.cc
##########
@@ -20,6 +20,7 @@
#include <memory>
#include <string>
#include <utility>
+#include <vector>
Review comment:
nit: is this import necessary?
##########
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic_test.cc
##########
@@ -20,6 +20,7 @@
#include <memory>
#include <string>
#include <utility>
+#include <vector>
Review comment:
We have a tool called include-what-you-use, though I don't think it's
been run a while. It might be good to give that a try again. (IIRC, it's a bit
finicky to set up.)
##########
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic_test.cc
##########
@@ -20,6 +20,7 @@
#include <memory>
#include <string>
#include <utility>
+#include <vector>
Review comment:
https://arrow.apache.org/docs/developers/cpp/development.html#cleaning-includes-with-include-what-you-use-iwyu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
