paleolimbot commented on a change in pull request #11592:
URL: https://github.com/apache/arrow/pull/11592#discussion_r741223425
##########
File path: r/R/dplyr-functions.R
##########
@@ -848,6 +848,21 @@ nse_funcs$wday <- function(x,
Expression$create("day_of_week", x, options = list(count_from_zero = FALSE,
week_start = week_start))
}
+nse_funcs$is.Date <- function(x) {
+ lubridate::is.Date(x) ||
Review comment:
It's already in `Suggests` which seems to be the right place for this?
(i.e., no namespace load until the function is called and since this is a
translation of a lubridate function, it's unlikely this will get called by a
user without lubridate installed?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
