save-buffer commented on a change in pull request #11579:
URL: https://github.com/apache/arrow/pull/11579#discussion_r744142025
##########
File path: cpp/src/arrow/compute/exec/hash_join.h
##########
@@ -56,19 +56,36 @@ class ARROW_EXPORT HashJoinSchema {
const std::string& left_field_name_prefix,
const std::string& right_field_name_prefix);
+ Result<Expression> BindFilter(Expression filter, const Schema& left_schema,
+ const Schema& right_schema);
std::shared_ptr<Schema> MakeOutputSchema(const std::string&
left_field_name_prefix,
const std::string&
right_field_name_prefix);
+ bool HasLeftPayload() { return HasPayload(0); }
Review comment:
Actually thinking about this one more too, I think it would be better to
leave it as some sort of positive, as the code paths that use this all check if
a payload exists, not if a payload doesn't exist. A different name could be
"LeftPayloadExists" or "LeftPayloadIsNonempty".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
