save-buffer commented on a change in pull request #11579:
URL: https://github.com/apache/arrow/pull/11579#discussion_r746911168
##########
File path: cpp/src/arrow/compute/exec/expression.h
##########
@@ -91,6 +91,9 @@ class ARROW_EXPORT Expression {
/// Return true if this expression could evaluate to true.
bool IsSatisfiable() const;
+ /// Return true if this expression has no clauses.
+ bool IsEmpty() const;
Review comment:
Well I think it's more of just a gotcha kind of thing. You're allowed to
create an object that's in an invalid state, and the rest of the codebase
assumes it's not in that state. My thinking is that if you're allowed to create
an object in that state, it should be considered a valid value, and should
therefore be checked against.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
