jorisvandenbossche commented on a change in pull request #11505:
URL: https://github.com/apache/arrow/pull/11505#discussion_r744905393
##########
File path: docs/source/developers/python.rst
##########
@@ -335,6 +335,11 @@ virtualenv) enables cmake to choose the python executable
which you are using.
For any other C++ build challenges, see :ref:`cpp-development`.
+In case you may need to rebuild the C++ part due to errors in the process it is
+advisable to delete the content of the build folder with command ``rm -rf *``
+from the build folder itself. If the build has passed successfully and you
need to rebuild
Review comment:
(of course, assuming that you would then run `git clean` from the root
of the repo)
##########
File path: docs/source/developers/python.rst
##########
@@ -335,6 +335,11 @@ virtualenv) enables cmake to choose the python executable
which you are using.
For any other C++ build challenges, see :ref:`cpp-development`.
+In case you may need to rebuild the C++ part due to errors in the process it is
+advisable to delete the content of the build folder with command ``rm -rf *``
+from the build folder itself. If the build has passed successfully and you
need to rebuild
Review comment:
The `rm -rf *` could also be changed to `rm -rf /cpp/build` to make this
more explicit (and without needing to be run from that directory).
I think a possible advantage of `rm` vs `git clean` is that the clean
command will remove everything else as well (eg if you have multiple build
directories (although a beginning contributor won't have this), or sphinx
doctrees / doc output, etc)
##########
File path: docs/source/developers/python.rst
##########
@@ -55,12 +55,15 @@ like so:
.. code-block:: shell
- pytest pyarrow
+ pytest arrow/python/pyarrow
Review comment:
That's certainly true, but _most_ of the other commands on this page are
written assuming you are located just above the arrow repo. So for consistency
(and for being more explicit), I think we can still update it.
And then any python programmer will still be able to understand how to edit
it according to their location :)
(BTW, we actually ran into this because of the combination that the guide
currently recommends to create a "pyarrow" virtualenv, and then doing `pytest
pyarrow` following the other instructions, it tried to run the tests of the all
packages in the virtualenv ... Now the virtualenv is renamed, that's of course
less of an issue)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
