thisisnic commented on a change in pull request #11751:
URL: https://github.com/apache/arrow/pull/11751#discussion_r754329549
##########
File path: r/R/type.R
##########
@@ -107,17 +111,48 @@ UInt32 <- R6Class("UInt32", inherit = FixedWidthType)
UInt64 <- R6Class("UInt64", inherit = FixedWidthType)
Float16 <- R6Class("Float16", inherit = FixedWidthType)
Float32 <- R6Class("Float32", inherit = FixedWidthType)
-Float64 <- R6Class("Float64", inherit = FixedWidthType)
+Float64 <- R6Class("Float64",
+ inherit = FixedWidthType,
+ public = list(
+ code = function() call("float64")
+ )
+)
Review comment:
Yeah, that's why I was wondering if it was something to change or not -
I think it's inevitably a little confusing either way! Perhaps having it show
`float64()` as it was before would be better as it matches the corresponding
C++ function?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
