thisisnic commented on a change in pull request #11751:
URL: https://github.com/apache/arrow/pull/11751#discussion_r754334616
##########
File path: r/R/type.R
##########
@@ -40,7 +40,8 @@ DataType <- R6Class("DataType",
fields = function() {
DataType__fields(self)
},
- export_to_c = function(ptr) ExportType(self, ptr)
+ export_to_c = function(ptr) ExportType(self, ptr),
+ code = function() call2("unknown_type", self$ToString())
Review comment:
Yeah - I don't 100% understand all of this - but I guess that approach
would mean that errors would be more obvious, more likely to get reported, and
then we know to implement the `code` public method for that class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
