romainfrancois commented on a change in pull request #11751:
URL: https://github.com/apache/arrow/pull/11751#discussion_r761974736



##########
File path: r/R/type.R
##########
@@ -55,6 +59,12 @@ DataType$import_from_c <- ImportType
 INTEGER_TYPES <- as.character(outer(c("uint", "int"), c(8, 16, 32, 64), 
paste0))
 FLOAT_TYPES <- c("float16", "float32", "float64", "halffloat", "float", 
"double")
 
+code_carefully <- function(type, msg) {

Review comment:
       Another way could be to always emit code, but inject call to `stop()` or 
`abort()` on unsupported types, i.e. we'd get: 
   
   ```r
   struct(a = stop("Unsupported type: <day_time_interval>"))
   ```
   
   This might be more useful to the user of `$code()`
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to