lidavidm commented on a change in pull request #11507:
URL: https://github.com/apache/arrow/pull/11507#discussion_r762146369



##########
File path: cpp/src/arrow/flight/sql/CMakeLists.txt
##########
@@ -66,36 +66,34 @@ else()
                                       ${ARROW_TEST_LINK_LIBS})
 endif()
 
-add_arrow_test(flight_sql_test
-               SOURCES
-               client_test.cc
-               server_test.cc
-               example/sqlite_sql_info.cc
-               STATIC_LINK_LIBS
-               ${ARROW_FLIGHT_SQL_TEST_LINK_LIBS}
-               LABELS
-               "arrow_flight_sql")
-
 # Build test server for unit tests
 if(ARROW_BUILD_TESTS OR ARROW_BUILD_EXAMPLES)
   find_package(SQLite3Alt REQUIRED)
 
-  add_executable(flight_sql_test_server
-                 test_server_cli.cc
-                 example/sqlite_sql_info.cc
-                 example/sqlite_statement.cc
-                 example/sqlite_statement_batch_reader.cc
-                 example/sqlite_server.cc
-                 example/sqlite_tables_schema_batch_reader.cc)
+  set(flight_sql_test_server_SRCS

Review comment:
       Ah, my bad, somehow I got mixed up and thought the server sources were 
getting built into the client CLI. This looks fine.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to