jorisvandenbossche commented on pull request #9702: URL: https://github.com/apache/arrow/pull/9702#issuecomment-986755588
Small note: I see that in one of your recent commits, you changes all lower case (eg `enable_dictionary`) to camel case (`GetEnableDictionary`). I am not fully sure, but I think we actually do use lower case for setter/getter methods elsewhere (https://google.github.io/styleguide/cppguide.html#Function_Names also mentions this is allowed) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
