HashidaTKS commented on a change in pull request #11931:
URL: https://github.com/apache/arrow/pull/11931#discussion_r767949700
##########
File path: csharp/src/Apache.Arrow/Column.cs
##########
@@ -62,7 +62,7 @@ private bool ValidateArrayDataTypes()
{
for (int i = 0; i < Data.ArrayCount; i++)
{
- if (Data.Array(i).Data.DataType != Field.DataType)
+ if (Data.Array(i).Data.DataType.TypeId !=
Field.DataType.TypeId)
Review comment:
Don't we need to also compare other members?
* `Children` when it is `NestedType`
* `ByteWidth` when it is `FixedSizeBinaryType`
I suppose we need to create a new `ArrowType` comparer for the product
projects like `ArrayTypeComparer` of `Apache.Arrow.Tests` and use it.
https://github.com/apache/arrow/blob/master/csharp/test/Apache.Arrow.Tests/ArrayTypeComparer.cs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
