Jimexist commented on a change in pull request #1408:
URL: https://github.com/apache/arrow-datafusion/pull/1408#discussion_r769181548
##########
File path: datafusion/src/physical_plan/expressions/sum.rs
##########
@@ -54,8 +56,15 @@ pub fn sum_return_type(arg_type: &DataType) ->
Result<DataType> {
DataType::UInt8 | DataType::UInt16 | DataType::UInt32 |
DataType::UInt64 => {
Ok(DataType::UInt64)
}
- DataType::Float32 => Ok(DataType::Float32),
- DataType::Float64 => Ok(DataType::Float64),
+ // In the https://www.postgresql.org/docs/8.2/functions-aggregate.html
doc,
Review comment:
```suggestion
// In the
https://www.postgresql.org/docs/current/functions-aggregate.html doc,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
