bkmgit commented on a change in pull request #11882:
URL: https://github.com/apache/arrow/pull/11882#discussion_r775909659
##########
File path: cpp/src/arrow/compute/kernels/scalar_compare.cc
##########
@@ -68,6 +72,50 @@ struct GreaterEqual {
}
};
+struct BetweenLessEqualLessEqual {
+ template <typename T, typename Arg0, typename Arg1, typename Arg2>
+ static constexpr T Call(KernelContext*, const Arg0& middle, const Arg1& left,
+ const Arg2& right, Status*) {
+ static_assert(std::is_same<T, bool>::value && std::is_same<Arg0,
Arg1>::value &&
+ std::is_same<Arg1, Arg2>::value,
+ "");
+ return (left <= middle) && (middle <= right);
+ }
+};
+
+struct BetweenLessThanLessEqual {
+ template <typename T, typename Arg0, typename Arg1, typename Arg2>
+ static constexpr T Call(KernelContext*, const Arg0& middle, const Arg1& left,
+ const Arg2& right, Status*) {
+ static_assert(std::is_same<T, bool>::value && std::is_same<Arg0,
Arg1>::value &&
+ std::is_same<Arg1, Arg2>::value,
+ "");
+ return (left < middle) && (middle <= right);
+ }
+};
+
+struct BetweenLessEqualLessThan {
+ template <typename T, typename Arg0, typename Arg1, typename Arg2>
+ static constexpr T Call(KernelContext*, const Arg0& middle, const Arg1& left,
+ const Arg2& right, Status*) {
+ static_assert(std::is_same<T, bool>::value && std::is_same<Arg0,
Arg1>::value &&
+ std::is_same<Arg1, Arg2>::value,
+ "");
+ return (left <= middle) && (middle < right);
+ }
+};
+
+struct BetweenLessThanLessThan {
+ template <typename T, typename Arg0, typename Arg1, typename Arg2>
+ static constexpr T Call(KernelContext*, const Arg0& middle, const Arg1& left,
+ const Arg2& right, Status*) {
+ static_assert(std::is_same<T, bool>::value && std::is_same<Arg0,
Arg1>::value &&
+ std::is_same<Arg1, Arg2>::value,
+ "");
+ return (left < middle) && (middle < right);
+ }
+};
Review comment:
Ok. Am happy to attempt something similar to the round function, though
it would be nice if it is for both between and compare functions since that
would make maintenance and code reuse easier.
For string comparison, some options that give a comparison key similar to a
sort key will likely be needed.
@edponce Light review would be helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
