sum12 opened a new pull request #1112:
URL: https://github.com/apache/arrow-rs/pull/1112


   The patch extends the current implementation to allow passing a custom
   datetime_re and datetime_format to the ReaderBuilder.
   
   datetime_re is used infer schema of the csv and then datetime_format is
   used to parse the actual string to a Date64.
   ofcourse  passing non-compatible datetime_re and datetime_format values
   is going to fail the parsing or inference, however it is an expected but
   hard-to-detect failure.
   
   # Which issue does this PR close?
   
   <!---
   We generally require a GitHub issue to be filed for all bug fixes and 
enhancements and this helps us generate change logs for our releases. You can 
link an issue to this PR using the GitHub syntax. For example `Closes #123` 
indicates that this PR will close issue #123.
   -->
   
   Closes #.
   
   # Rationale for this change
    
   Sometimes csv files follow non-standard datetime format. Arrow does not 
really care for the datetime format stored in the csv but merely 
guesses/assumes it to be of a certain fomrat. The change extends the csv reader 
to use a custom fromat.
    <!---
    Why are you proposing this change? If this is already explained clearly in 
the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your 
changes and offer better suggestions for fixes.
   -->
   
   # What changes are included in this PR?
   
   <!---
   There is no need to duplicate the description in the issue here but it is 
sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   Any external libraries relying on ReaderBuilder and Reader structs will have 
to be updated to the new new API, 
   
   <!---
   If there are user-facing changes then we may require documentation to be 
updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking 
change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to