alamb commented on a change in pull request #1510:
URL: https://github.com/apache/arrow-datafusion/pull/1510#discussion_r777007049
##########
File path: datafusion/Cargo.toml
##########
@@ -77,6 +77,7 @@ rand = "0.8"
avro-rs = { version = "0.13", features = ["snappy"], optional = true }
num-traits = { version = "0.2", optional = true }
pyo3 = { version = "0.14", optional = true }
+statrs = "0.15"
Review comment:
I would prefer to avoid more dependencies for datafusion if possible
(e.g. so we don't have to deal with
https://github.com/apache/arrow-datafusion/issues/1498)
It seems to me like a factorial implementation will not change much and the
code from statrs is fairly simple;
https://docs.rs/statrs/0.15.0/src/statrs/function/factorial.rs.html#92-108
Perhaps we can implement this code directly in datafusion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
