guyuqi commented on a change in pull request #12009:
URL: https://github.com/apache/arrow/pull/12009#discussion_r779576032
##########
File path: go/arrow/math/Makefile
##########
@@ -37,27 +41,42 @@ INTEL_SOURCES := \
int64_avx2_amd64.s int64_sse4_amd64.s \
uint64_avx2_amd64.s uint64_sse4_amd64.s
+ARM_SOURCES := \
+ float64_neon_arm64.s \
+ int64_neon_arm64.s \
+ uint64_neon_arm64.s
+
.PHONEY: assembly
-assembly: $(INTEL_SOURCES)
+#ifeq ($(GOARCH), arm64)
+assembly: $(ARM_SOURCES)
+#else
+#assembly: $(INTEL_SOURCES)
+#endif
Review comment:
Agreed. I'll add a comment in assembly files to retain the related info
to track this PR, thanks.
(P.S. For I'm limited to access the PC in these several days, I will
update the related files on this Sunday )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
