xudong963 commented on pull request #1566: URL: https://github.com/apache/arrow-datafusion/pull/1566#issuecomment-1014105703
> @xudong963 This might be a bit nitpicky but this will enter an infinite loop if multiple cross joins are required for a plan. As an example, the following explain select will never finish: > > ``` > > ❯ create table part as select 1 as p_partkey, 2 as p_partprice, 3 as p_partprice > _taxadded; > 0 rows in set. Query took 0.036 seconds. > ❯ create table lineitem as select 1 as l_itemkey; > 0 rows in set. Query took 0.001 seconds. > ❯ create table supplier as select 1 as s_suppkey; > 0 rows in set.0 rows in set. Query took 0.001 seconds. Query took 0.001 seconds. > ❯ explain select * from part,supplier,lineitem where p_partprice=p_partprice_tax > added; > ``` > > In practice I'm not sure how much of a deal this is as it requires multiple cross joins with a filter that operates solely on a single table. Good catch, I think we should process the case because we can't guarantee what kind of queries the user will write 😁 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
