james727 edited a comment on pull request #1618: URL: https://github.com/apache/arrow-datafusion/pull/1618#issuecomment-1018821372
Thanks for the review @alamb! We already have some active discussion on this PR but I'd propose the following next steps on my end: 1. Add the suggested tests (and fix any associated breakage) 2. Roll back the filter duplication optimization to only apply for `INNER` joins (as discussed in https://github.com/apache/arrow-datafusion/pull/1618#discussion_r789951842) I think the other main open thread is around the term `preserved` and its definition, it seems there is some misalignment (I probably just used the wrong definition). What are your thoughts on the best way to decide on the terminology/definitions to use here (and document it going forward)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
