james727 commented on pull request #1618: URL: https://github.com/apache/arrow-datafusion/pull/1618#issuecomment-1019025990
@alamb I think this is ready for another look. I've updated the logic as discussed (do not duplicate filters on the join column unless it's an inner join) and added a bunch of tests. I also extended the comment on `lr_is_preserved` to hopefully be clear about how I've defined "preserved" in this PR. I think the way I have defined it, the logic is correct, but I'm curious your thoughts on whether this is the best concept to move forward with. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
