dragosmg commented on a change in pull request #12240:
URL: https://github.com/apache/arrow/pull/12240#discussion_r791797628
##########
File path: r/tests/testthat/test-Array.R
##########
@@ -985,3 +985,14 @@ test_that("Array to C-interface", {
delete_arrow_schema(schema_ptr)
delete_arrow_array(array_ptr)
})
+
+test_that("Array coverts timestamps with missing timezone /assumed local tz
correctly", {
+ withr::with_envvar(c(TZ = "America/Chicago"), {
+ a <- as.POSIXct("1970-01-01 00:00:00")
+ attr(a, "tzone") <- Sys.getenv("TZ")
Review comment:
👍🏻 I think we are all on the same page. In this situation what is the
solution? I think we can attach the local / system timezone when it isn't
passed explicitly (and this would theoretically solve this Jira issue). Should
we then open a follow-up issue regarding the printing of arrow timestamps in R
(which falls outside the scope of this ticket)? Which would be an alignment
with [ARROW-14567](https://issues.apache.org/jira/browse/ARROW-14567)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
