Jimexist commented on a change in pull request #1665:
URL: https://github.com/apache/arrow-datafusion/pull/1665#discussion_r791457473
##########
File path: datafusion/src/datasource/object_store/mod.rs
##########
@@ -141,7 +141,7 @@ pub trait ObjectStore: Sync + Send + Debug {
let suffix = suffix.to_owned();
Ok(Box::pin(file_stream.filter(move |fr| {
let has_suffix = match fr {
- Ok(f) => f.path().ends_with(&suffix),
+ Ok(f) => f.path().ends_with(&suffix) &&
!should_filter_out(f.path()),
Review comment:
can you combine both logic into a more cohesive helper function
##########
File path: datafusion/src/datasource/object_store/mod.rs
##########
@@ -159,6 +159,16 @@ pub trait ObjectStore: Sync + Send + Debug {
/// Get object reader for one file
fn file_reader(&self, file: SizedFile) -> Result<Arc<dyn ObjectReader>>;
}
+/// Checks if we should filter out this path name
+///
https://github.com/apache/spark/blob/5b91381b9bcea27b7be6d9cef852efbd6c23d98a/core/src/main/scala/org/apache/spark/util/HadoopFSUtils.scala#L358
+fn do_path_filter_with_suffix(path: &str, suffix: &str) -> bool {
+ let exclude = path.starts_with('_') && !path.contains('=')
+ || path.starts_with('.')
+ || path.ends_with("._COPYING_");
Review comment:
Conflicting logic with parquet suffix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
