Ted-Jiang commented on a change in pull request #1665: URL: https://github.com/apache/arrow-datafusion/pull/1665#discussion_r792393338
########## File path: datafusion/src/datasource/object_store/mod.rs ########## @@ -141,7 +141,7 @@ pub trait ObjectStore: Sync + Send + Debug { let suffix = suffix.to_owned(); Ok(Box::pin(file_stream.filter(move |fr| { let has_suffix = match fr { - Ok(f) => f.path().ends_with(&suffix), + Ok(f) => do_path_filter_with_suffix(f.path(), &suffix), Review comment: @houqp thanks a lot for your kindly explain! i got that object_store should be highly abstract. This filter login from spark is in `HadoopFSUtils`. So i think maybe i will keep the code clean, put this in out customized ObjectStore for hadoop. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org