bkmgit commented on a change in pull request #12321: URL: https://github.com/apache/arrow/pull/12321#discussion_r797840095
########## File path: cpp/src/arrow/compute/kernels/scalar_string_internal.h ########## @@ -213,7 +213,7 @@ static FunctionDoc StringPredicateDoc(std::string summary, std::string descripti return FunctionDoc{std::move(summary), std::move(description), {"strings"}}; } -static FunctionDoc StringClassifyDoc(std::string class_summary, std::string class_desc, +static inline FunctionDoc StringClassifyDoc(std::string class_summary, std::string class_desc, bool non_empty) { Review comment: ```suggestion static inline FunctionDoc StringClassifyDoc(std::string class_summary, std::string class_desc, bool non_empty) { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org