tustvold commented on a change in pull request #1248:
URL: https://github.com/apache/arrow-rs/pull/1248#discussion_r798942622
##########
File path: arrow/src/compute/kernels/filter.rs
##########
@@ -119,17 +147,83 @@ impl<'a> Iterator for SlicesIterator<'a> {
}
}
+/// An iterator of `usize` whose index in [`BooleanArray`] is true
+///
+/// This provides the best performance on all but the most selective
predicates, where the
Review comment:
NULLs within the filter itself are handled by `prep_null_mask_filter` -
i.e. they are converted to false prior to any of this code seeing it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
