tustvold commented on a change in pull request #1248:
URL: https://github.com/apache/arrow-rs/pull/1248#discussion_r798959128
##########
File path: arrow/src/compute/kernels/filter.rs
##########
@@ -696,7 +1273,8 @@ mod tests {
.flat_map(|(idx, v)| v.then(|| idx))
.collect();
- assert_eq!(bits, expected_bits);
+ assert_eq!(slice_bits, expected_bits);
+ assert_eq!(index_bits, expected_bits);
}
#[test]
Review comment:
Eeh... I'm fairly confident, but more tests couldn't hurt. I'll see what
I can come up with
Edit: will do this first thing tomorrow - my brain is a little bit
:fried_egg:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
