alamb commented on a change in pull request #1776:
URL: https://github.com/apache/arrow-datafusion/pull/1776#discussion_r802037449
##########
File path: datafusion/src/physical_plan/hash_join.rs
##########
@@ -278,6 +279,14 @@ impl ExecutionPlan for HashJoinExec {
self.right.output_partitioning()
}
+ fn output_ordering(&self) -> Option<&[PhysicalSortExpr]> {
+ None
Review comment:
👍 makes sense.
I think that only applies for inner joins though (as outer joins may stick
nulls into inconvenient places 😆 )
##########
File path: datafusion/src/physical_plan/hash_join.rs
##########
@@ -278,6 +279,14 @@ impl ExecutionPlan for HashJoinExec {
self.right.output_partitioning()
}
+ fn output_ordering(&self) -> Option<&[PhysicalSortExpr]> {
+ None
Review comment:
👍 makes sense.
I think that only applies for inner joins though (as some types of outer
joins may stick nulls into inconvenient places 😆 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
