alamb commented on a change in pull request #1807:
URL: https://github.com/apache/arrow-datafusion/pull/1807#discussion_r804182134
##########
File path: CHANGELOG.md
##########
@@ -21,7 +21,6 @@ Changelogs are maintained separately for each subproject.
Please check out the
changelog file within each subproject folder for more details:
* [Datafusion CHANGELOG](./datafusion/CHANGELOG.md)
-* [Datafusion Python Binding CHANGELOG](./python/CHANGELOG.md)
Review comment:
python has been moved to its own crate, I believe.
##########
File path: dev/release/update_change_log.sh
##########
@@ -50,14 +50,14 @@ OUTPUT_PATH="${PROJECT}/CHANGELOG.md"
pushd ${SOURCE_TOP_DIR}
# reset content in changelog
-git co "${SINCE_TAG}" "${OUTPUT_PATH}"
+git checkout "${SINCE_TAG}" "${OUTPUT_PATH}"
Review comment:
my mac didn't like `git co` 😢
##########
File path: dev/release/update_change_log.sh
##########
@@ -50,14 +50,14 @@ OUTPUT_PATH="${PROJECT}/CHANGELOG.md"
pushd ${SOURCE_TOP_DIR}
# reset content in changelog
-git co "${SINCE_TAG}" "${OUTPUT_PATH}"
+git checkout "${SINCE_TAG}" "${OUTPUT_PATH}"
# remove license header so github-changelog-generator has a clean base to
append
-sed -i '1,18d' "${OUTPUT_PATH}"
+sed -i.bak '1,18d' "${OUTPUT_PATH}"
Review comment:
Likewise, apparently `sed` from mac is slightly different than linux
https://stackoverflow.com/questions/5694228/sed-in-place-flag-that-works-both-on-mac-bsd-and-linux
##########
File path: dev/release/update_change_log.sh
##########
@@ -50,14 +50,14 @@ OUTPUT_PATH="${PROJECT}/CHANGELOG.md"
pushd ${SOURCE_TOP_DIR}
# reset content in changelog
-git co "${SINCE_TAG}" "${OUTPUT_PATH}"
+git checkout "${SINCE_TAG}" "${OUTPUT_PATH}"
# remove license header so github-changelog-generator has a clean base to
append
-sed -i '1,18d' "${OUTPUT_PATH}"
+sed -i.bak '1,18d' "${OUTPUT_PATH}"
docker run -it --rm \
-e CHANGELOG_GITHUB_TOKEN=$CHANGELOG_GITHUB_TOKEN \
-v "$(pwd)":/usr/local/src/your-app \
- githubchangeloggenerator/github-changelog-generator:1.16.2 \
+ githubchangeloggenerator/github-changelog-generator \
Review comment:
use latest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
