[GitHub] [arrow-datafusion] alamb commented on a change in pull request #1807: Update CHANGELOG.md, update release scripts

Fri, 11 Feb 2022 03:02:03 -0800 


alamb commented on a change in pull request #1807:
URL: https://github.com/apache/arrow-datafusion/pull/1807#discussion_r804548747



##########
File path: dev/release/update_change_log.sh
##########
@@ -50,14 +50,14 @@ OUTPUT_PATH="${PROJECT}/CHANGELOG.md"
 pushd ${SOURCE_TOP_DIR}
 
 # reset content in changelog
-git co "${SINCE_TAG}" "${OUTPUT_PATH}"
+git checkout "${SINCE_TAG}" "${OUTPUT_PATH}"
 # remove license header so github-changelog-generator has a clean base to 
append
-sed -i '1,18d' "${OUTPUT_PATH}"
+sed -i.bak '1,18d' "${OUTPUT_PATH}"
 
 docker run -it --rm \
     -e CHANGELOG_GITHUB_TOKEN=$CHANGELOG_GITHUB_TOKEN \
     -v "$(pwd)":/usr/local/src/your-app \
-    githubchangeloggenerator/github-changelog-generator:1.16.2 \
+    githubchangeloggenerator/github-changelog-generator \

Review comment:
       🤔  
https://hub.docker.com/r/githubchangeloggenerator/github-changelog-generator/tags
   
   Seems like `latest` has no other tag (as in `latest` is newer than `1.16.2` 
but there are no other numbered versions newer than `1.16.2`) 😞 
   
   ![Screen Shot 2022-02-11 at 6 00 42 
AM](https://user-images.githubusercontent.com/490673/153580452-54ccec0a-47bb-48b2-b5e9-ec7967d58920.png)
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to