alamb commented on a change in pull request #1322:
URL: https://github.com/apache/arrow-rs/pull/1322#discussion_r808295938
##########
File path: parquet/src/file/metadata.rs
##########
@@ -467,6 +469,17 @@ impl ColumnChunkMetaData {
self.statistics.as_ref()
}
+ /// Returns `true` if this column chunk contains page encoding stats,
`false` otherwise.
+ pub fn has_page_encoding_stats(&self) -> bool {
Review comment:
I think this method is redundant with the `page_encoding_stats` as I
think most of the time any client code would process page_encoding_stats they
would likely use code like:
```rust
if let Some(page_encoding_stats) = metadata.page_encoding_stats() {
// do something with `page_encoding_stats`
```
However, I see it is consistent with the methods of this file (and I didn't
call this out in earlier PRs 😅 )
On the other hand, we haven't released the other methods (like
`has_bloom_filter` so it isn't too late to remove them)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
