cyb70289 commented on a change in pull request #12426:
URL: https://github.com/apache/arrow/pull/12426#discussion_r808625398



##########
File path: cpp/src/arrow/csv/options.h
##########
@@ -194,6 +194,9 @@ struct ARROW_EXPORT WriteOptions {
   /// This number can impact performance.
   int32_t batch_size = 1024;
 
+  /// Field delimiter
+  char delimiter = ',';

Review comment:
       Shall we treat the customized delimiter as non structural chars in 
non-quoted string checking [1]? Currently, it's hard coded to check `,` and 
`\r`, `\n`, `"`.
   
   https://github.com/apache/arrow/blob/master/cpp/src/arrow/csv/writer.cc#L213




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to