lafiona commented on a change in pull request #12489:
URL: https://github.com/apache/arrow/pull/12489#discussion_r817902884
##########
File path: dev/release/post-13-msys2.sh
##########
@@ -45,10 +45,13 @@ if ! git remote | grep -q '^upstream$'; then
exit 1
fi
+SOURCE_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
+source "${SOURCE_DIR}/git-vars.sh"
+
echo "Updating repository: ${repository}"
git fetch --all --prune --tags --force -j$(nproc)
-git checkout master
-git rebase upstream/master
+git checkout ${DEFAULT_BRANCH}
+git rebase upstream/${DEFAULT_BRANCH}
Review comment:
Thank you for this feedback, @kou.
I initially included the change in this file to use the default branch of
the `msys2/MINGW-packages` repository, to make the transition smoother if they
change the name of their default branch. My thought was that after the `cd`
call on line 35, sourcing `git-vars.sh` would get the default branch value of
the `msys2/MINGW-packages` repository. ~~However, I have realized that in order
for the `SOURCE_DIR` variable to be computed correctly, this script would need
to be executed with a full path.~~
I will remove the change to use the `git-vars.sh` in this file and update
the pull request description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
