ihji commented on a change in pull request #11039:
URL: https://github.com/apache/beam/pull/11039#discussion_r421271157
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/PackageUtil.java
##########
@@ -442,45 +448,56 @@ public static StagingResult uploaded(PackageAttributes
attributes) {
/** Holds the metadata necessary to stage a file or confirm that a staged
file has not changed. */
@AutoValue
abstract static class PackageAttributes {
-
- public static PackageAttributes forFileToStage(File source, String
stagingPath)
+ public static PackageAttributes forFileToStage(File file, String
stagingPath)
throws IOException {
+ return forFileToStage(file.getPath(), null, stagingPath);
+ }
+ public static PackageAttributes forFileToStage(
Review comment:
I think we can remove those hashing and zipping. It's redundant except
test cases. Will update the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
