ihji commented on a change in pull request #11039:
URL: https://github.com/apache/beam/pull/11039#discussion_r426924859
##########
File path:
runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/util/PackageUtilTest.java
##########
@@ -195,7 +187,7 @@ public void testFileWithExtensionPackageNamingAndSize()
throws Exception {
PackageAttributes attr = makePackageAttributes(tmpFile, null);
DataflowPackage target = attr.getDestination();
- assertThat(target.getName(), RegexMatcher.matches("file-" + HASH_PATTERN +
".txt"));
+ assertThat(target.getName(), RegexMatcher.matches(UUID_PATTERN + ".txt"));
Review comment:
but it only checks whether the staged file name has the same extension
(vs. checks whether the staged file name is in the form of UUID with the same
extension)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
