chadrik commented on a change in pull request #11632:
URL: https://github.com/apache/beam/pull/11632#discussion_r421789390
##########
File path: sdks/python/apache_beam/dataframe/convert.py
##########
@@ -16,13 +16,23 @@
from __future__ import absolute_import
+import typing
+
import inspect
from apache_beam import pvalue
from apache_beam.dataframe import expressions
from apache_beam.dataframe import frame_base
from apache_beam.dataframe import transforms
+if typing.TYPE_CHECKING:
+ # pylint: disable=ungrouped-imports
+ from typing import Any
+ from typing import Dict
+ from typing import Tuple
+ from typing import Union
Review comment:
Scoping these imports is not a bad idea since it keeps the module
namespace cleaner, but there are a couple of issues with this:
- once we get to python 3.x, and move from type comments to annotations,
this will fail, as we'll be referencing non-existent objects in our
annotations.
- it's not consistent with how we've done this throughout the rest of the
code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
