robertwb commented on a change in pull request #11632:
URL: https://github.com/apache/beam/pull/11632#discussion_r422233278
##########
File path: sdks/python/apache_beam/dataframe/convert.py
##########
@@ -16,13 +16,23 @@
from __future__ import absolute_import
+import typing
+
import inspect
from apache_beam import pvalue
from apache_beam.dataframe import expressions
from apache_beam.dataframe import frame_base
from apache_beam.dataframe import transforms
+if typing.TYPE_CHECKING:
+ # pylint: disable=ungrouped-imports
+ from typing import Any
+ from typing import Dict
+ from typing import Tuple
+ from typing import Union
Review comment:
So lint complains about unguarded imports, so I put them back. We'll
just to a massive sweep to fix these when we change to use type annotations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
