kkucharc commented on a change in pull request #11567:
URL: https://github.com/apache/beam/pull/11567#discussion_r423010025
##########
File path: sdks/python/apache_beam/testing/load_tests/load_test.py
##########
@@ -67,22 +82,30 @@ def _str_to_boolean(value):
class LoadTest(object):
+ """Base class for all integration and performance tests which export
+ metrics to external databases: BigQuery or/and InfluxDB.
+
+ Refer to :class:`~apache_beam.testing.load_tests.LoadTestOptions` for more
+ information on the required pipeline options.
+
+ If using InfluxDB with Basic HTTP authentication enabled, provide the
+ following environment options: `INFLUXDB_USER` and `INFLUXDB_USER_PASSWORD`.
+ """
def __init__(self):
# Be sure to set blocking to false for timeout_ms to work properly
self.pipeline = TestPipeline(is_integration_test=True, blocking=False)
assert not self.pipeline.blocking
- load_test_options = self.pipeline.get_pipeline_options().view_as(
- LoadTestOptions)
- self.timeout_ms = load_test_options.timeout_ms
- self.input_options = load_test_options.input_options
- self.metrics_namespace = load_test_options.metrics_table or 'default'
- publish_to_bq = load_test_options.publish_to_big_query
+ options = self.pipeline.get_pipeline_options().view_as(LoadTestOptions)
+ self.timeout_ms = options.timeout_ms
+ self.input_options = options.input_options
+ self.metrics_namespace = options.metrics_table or 'default'
+ publish_to_bq = options.publish_to_big_query
if publish_to_bq is None:
Review comment:
Sure, then ok. Less changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
