kkucharc commented on a change in pull request #11567:
URL: https://github.com/apache/beam/pull/11567#discussion_r423012464
##########
File path: sdks/python/apache_beam/testing/load_tests/load_test_metrics_utils.py
##########
@@ -167,14 +175,15 @@ class MetricsReader(object):
A :class:`MetricsReader` retrieves metrics from pipeline result,
prepares it for publishers and setup publishers.
"""
- publishers = [] # type: List[ConsoleMetricsPublisher]
+ publishers = [] # type: List[Any]
def __init__(
self,
project_name=None,
bq_table=None,
bq_dataset=None,
publish_to_bq=False,
Review comment:
Well, I can see that inconsitent is `publish_to_bq` vs
`influxdb_options`, but if we plan to have only `influxdb_options` then it's
ok. Possibility I see here is to have something more generic like
`metrics_options` or `metrics_storage_options`. Then if changes like this will
happen in the future, there will be less to change.
The other possibility is changing it in a way it will be changed in Java SDK
as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
