amaliujia commented on a change in pull request #10946: URL: https://github.com/apache/beam/pull/10946#discussion_r426967410
########## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/utils/TVFStreamingUtils.java ########## @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.sdk.extensions.sql.impl.utils; + +/** Provides static constants or utils for TVF streaming. */ +public class TVFStreamingUtils { Review comment: `SqlWindowTableFunction` is a class in Calcite (since 1.22.0). After we successfully upgrade to newer version of Calcite (I hope), we can remove `SqlWindowTableFunction`, thus there is a need to keep a `TVFStreamingUtils`. There could be an argument though that such constants can be put into `SqlWindowTableFunction` in Calcite. We can leave such discussion in the future. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
