[GitHub] [beam] amaliujia commented on a change in pull request #10946: [BEAM-9363] TUMBLE as TVF

[GitBox]

amaliujia commented on a change in pull request #10946:
URL: https://github.com/apache/beam/pull/10946#discussion_r426968398



##########
File path: 
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SqlAnalyzer.java
##########
@@ -175,6 +185,37 @@ private void addBuiltinFunctionsToCatalog(SimpleCatalog 
catalog, AnalyzerOptions
                     Mode.SCALAR,
                     ImmutableList.of(resolvedFunc.getSignature())))
         .forEach(catalog::addFunction);
+
+    FunctionArgumentType retType =
+        new FunctionArgumentType(SignatureArgumentKind.ARG_TYPE_RELATION);
+
+    FunctionArgumentType inputTableType =
+        new FunctionArgumentType(SignatureArgumentKind.ARG_TYPE_RELATION);
+
+    FunctionArgumentType descriptorType =
+        new FunctionArgumentType(
+            SignatureArgumentKind.ARG_TYPE_DESCRIPTOR,
+            FunctionArgumentTypeOptionsProto.newBuilder()
+                .setDescriptorResolutionTableOffset(0)
+                .build(),
+            1);
+
+    FunctionArgumentType stringType =
+        new 
FunctionArgumentType(TypeFactory.createSimpleType(TypeKind.TYPE_STRING));
+
+    // TUMBLE
+    catalog.addTableValuedFunction(
+        new 
TableValuedFunction.ForwardInputSchemaToOutputSchemaWithAppendedColumnTVF(

Review comment:
       Yeah. And at least I am glad this name itself does not exceed 80 chars 
so it at least fits into a single line..




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org