sabhyankar commented on a change in pull request #11950:
URL: https://github.com/apache/beam/pull/11950#discussion_r437606598



##########
File path: 
sdks/java/io/splunk/src/main/java/org/apache/beam/sdk/io/splunk/SplunkEvent.java
##########
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.io.splunk;
+
+import static 
org.apache.beam.vendor.guava.v26_0_jre.com.google.common.base.Preconditions.checkNotNull;
+
+import com.google.auto.value.AutoValue;
+import com.google.gson.annotations.SerializedName;
+import javax.annotation.Nullable;
+
+/**
+ * A {@link SplunkEvent} describes a single payload sent to Splunk's Http 
Event Collector (HEC)
+ * endpoint.
+ *
+ * <p>Each object represents a single event and related metadata elements such 
as:
+ *
+ * <ul>
+ *   <li>time
+ *   <li>host
+ *   <li>source
+ *   <li>sourceType
+ *   <li>index
+ * </ul>
+ */
+@AutoValue
+public abstract class SplunkEvent {

Review comment:
       Thank for the pointer @pabloem 
   
   I have switched from using custom coders to DefaultSchema with 
AutoValueSchema.
   I noticed that in 
[AutoValueUtils](https://github.com/apache/beam/blob/c3a2dd89616faea5a2171ae6d8e39a77f6e39422/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/AutoValueUtils.java#L187-L191)
 that the build method should literally be called 'build'. This required me to 
change some of my method names.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to