sabhyankar commented on a change in pull request #11950:
URL: https://github.com/apache/beam/pull/11950#discussion_r438774319
##########
File path:
sdks/java/io/splunk/src/main/java/org/apache/beam/sdk/io/splunk/SplunkIO.java
##########
@@ -77,32 +78,48 @@
*
* PCollection<SplunkWriteError> errors =
* events.apply("WriteToSplunk",
- * SplunkIO.writeBuilder()
- * .withToken(token)
- * .withUrl(url)
- * .withBatchCount(batchCount)
- * .withParallelism(parallelism)
- * .withDisableCertificateValidation(true)
- * .build());
+ * SplunkIO.write(url, token)
+ * .withBatchCount(batchCount)
+ * .withParallelism(parallelism)
+ * .withDisableCertificateValidation(true));
* }</pre>
*/
@Experimental(Kind.SOURCE_SINK)
public class SplunkIO {
+ /**
+ * Write to Splunk's Http Event Collector (HEC).
+ *
+ * @param url splunk hec url
+ * @param token splunk hec authentication token
Review comment:
A token is required in order to use HEC and each end point has at-least
one token. So this would be a required param. (See: [Using http event
collector](https://docs.splunk.com/Documentation/Splunk/8.0.4/Data/UsetheHTTPEventCollector#Create_an_Event_Collector_token))
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
