alexeyinkin commented on code in PR #21959: URL: https://github.com/apache/beam/pull/21959#discussion_r918064730
########## playground/frontend/README.md: ########## @@ -85,6 +85,9 @@ For more information see See [CONTRIBUTE.md](CONTRIBUTE.md) The full list of commands can be found [here](https://flutter.dev/docs/reference/flutter-cli) +## Embedding +Page with playground has a vertical, iframe has its own vertical scroll. When user scrolls down the page and gets in playground viewport, inner scroll intercepts the outer, user gets stuck in playground iframe. Solution is to make playground to be opaque to scrolling until clicked. Playground has a container with css pointer-events: none, so user can't interact with it initially until click event happens. If clicked, pointer-events changes value to auto, inner scroll works. When user leaves the playground, iframe scroll becomes opaque to scrolling until next click. Function fix-playground-nested-scroll.js toggles css pointer-events property when click and mouseleave events are triggered. + Review Comment: This is hard to read without an example. I think I will add it myself when I'm done on my part. Sorry for the overhead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
