Sanil15 commented on code in PR #22576: URL: https://github.com/apache/beam/pull/22576#discussion_r944699404
########## runners/samza/src/main/java/org/apache/beam/runners/samza/util/SamzaExceptionListener.java: ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.runners.samza.util; + +import java.beans.PropertyChangeListener; +import java.beans.PropertyChangeSupport; +import java.util.Map; + +/** + * An ExceptionListener following Observer pattern. Any class implementing {@code + * PropertyChangeListener} can be registered with SamzaExceptionListener. Any runtime exception + * caught by {@code OpAdapter} will be notified to all registered PropertyChangeListener(s) as a + * {@code PropertyChangeEvent} + */ +public class SamzaExceptionListener { + private PropertyChangeSupport support; + private static final SamzaExceptionListener singletonExceptionListener = + new SamzaExceptionListener(); Review Comment: good call, used the same pattern as SamzaPipelineLifeCycleListener with autoservice to wire in Exception listeners ########## runners/samza/src/main/java/org/apache/beam/runners/samza/runtime/Op.java: ########## @@ -61,4 +61,8 @@ default void processSideInputWatermark(Instant watermark, OpEmitter<OutT> emitte default void processTimer(KeyedTimerData<K> keyedTimerData, OpEmitter<OutT> emitter) {} default void close() {} + + default String getFullOpName() { Review Comment: fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
