ryanthompson591 commented on code in PR #22550:
URL: https://github.com/apache/beam/pull/22550#discussion_r947300811
##########
sdks/python/setup.py:
##########
@@ -269,22 +269,21 @@ def get_portability_package_data():
# Transitive dep. Required for google-cloud-spanner v1.
# See: https://github.com/apache/beam/issues/22454
'google-api-core!=2.8.2,<3',
- # NOTE: Maintainers, please do not require google-auth>=2.x.x
- # Until this issue is closed
- # https://github.com/googleapis/google-cloud-python/issues/10566
'google-auth>=1.18.0,<3',
'google-auth-httplib2>=0.1.0,<0.2.0',
'google-cloud-datastore>=1.8.0,<2',
'google-cloud-pubsub>=2.1.0,<3',
'google-cloud-pubsublite>=1.2.0,<2',
- # GCP packages required by tests
+ ],
+ 'gcp_test': [
Review Comment:
I'm just confused why IO libraries like bigquery, bigtable, spanner are test
libraries. Seems like they are standard IO libraries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
