JustineKoa commented on a change in pull request #12042:
URL: https://github.com/apache/beam/pull/12042#discussion_r447186469



##########
File path: 
beam-ci/src/main/resources/io/jenkins/plugins/ExecuteBeamPipelineOnDataflowBuilder/config.jelly
##########
@@ -0,0 +1,36 @@
+<?jelly escape-by-default='true'?>

Review comment:
       I think it is jelly convention to put it in the directory named after 
the Builder it is tied to. I believe that's how the project is able to identify 
where the jelly files are for the Builder class.

##########
File path: 
beam-ci/src/main/resources/io/jenkins/plugins/ExecuteBeamPipelineOnDataflowBuilder/config.jelly
##########
@@ -0,0 +1,36 @@
+<?jelly escape-by-default='true'?>

Review comment:
       I think it is Jenkins convention to put it in the directory named after 
the Builder it is tied to. I believe that's how the project is able to identify 
where the jelly files are for the Builder class.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to