JustineKoa commented on a change in pull request #12042: URL: https://github.com/apache/beam/pull/12042#discussion_r448523037
########## File path: beam-ci/src/main/java/io/jenkins/plugins/ExecuteBeamPipelineOnDataflowBuilder.java ########## @@ -0,0 +1,206 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package io.jenkins.plugins; + +import hudson.Launcher; +import hudson.Extension; +import hudson.FilePath; +import hudson.util.FormValidation; +import hudson.model.AbstractProject; +import hudson.model.Run; +import hudson.model.TaskListener; +import hudson.tasks.Builder; +import hudson.tasks.BuildStepDescriptor; +import jenkins.util.SystemProperties; +import org.kohsuke.stapler.DataBoundConstructor; +import org.kohsuke.stapler.QueryParameter; + +import javax.servlet.ServletException; +import java.io.*; +import java.util.*; + +import jenkins.tasks.SimpleBuildStep; + +public class ExecuteBeamPipelineOnDataflowBuilder extends Builder implements SimpleBuildStep { + + private ProcessBuilder processBuilder; + private final String pathToCreds; + private final String pathToMainClass; + private final String pipelineOptions; + private final String buildReleaseOptions; + private boolean useJava; // if false, use Python + private boolean useGradle; // if false, use Maven + private ArrayList<String> command; + private boolean test; // if we are testing, the mock ProcessBuilder never starts + + @DataBoundConstructor + public ExecuteBeamPipelineOnDataflowBuilder(String pathToCreds, String pathToMainClass, String pipelineOptions, String buildReleaseOptions, boolean useJava, boolean useGradle) { + this.pathToCreds = pathToCreds; + this.pathToMainClass = pathToMainClass; + this.pipelineOptions = pipelineOptions; + this.buildReleaseOptions = buildReleaseOptions; + this.useJava = useJava; + this.useGradle = useGradle; + this.test = false; + } + + public void setProcessBuilder(ProcessBuilder processBuilder) { Review comment: Oh wow I didn't know these are made by default! Thanks ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
