chamikaramj commented on a change in pull request #12106:
URL: https://github.com/apache/beam/pull/12106#discussion_r451242654
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java
##########
@@ -893,6 +906,19 @@ public void deleteDataset(String projectId, String
datasetId)
ignoreInsertIds);
}
+ protected GoogleJsonError.ErrorInfo getErrorInfo(IOException e) {
+ GoogleJsonResponseException jsonCause = null;
Review comment:
We can further simplify :)
protected GoogleJsonError.ErrorInfo getErrorInfo(IOException e) {
if (!(e instanceof GoogleJsonResponseException)) {
return null;
}
GoogleJsonError jsonError = ((GoogleJsonResponseException)
e).getDetails();
...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
