Abacn commented on code in PR #24784:
URL: https://github.com/apache/beam/pull/24784#discussion_r1057897830
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BeamRowToStorageApiProtoTest.java:
##########
@@ -392,4 +415,11 @@ public void testMessageFromTableRow() throws Exception {
DynamicMessage nestedMsg = (DynamicMessage)
msg.getField(fieldDescriptors.get("nested"));
assertBaseRecord(nestedMsg);
}
+
+ @Test
Review Comment:
Thanks for the finding. However this test looks irrelevant to the class we
test against. We could simply replace "sqlTimestampValue" with a constant
timestamp with micros precision, like those "int64Value", "byteValue" in
BASE_ROW
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
