ahmedabu98 commented on code in PR #24784:
URL: https://github.com/apache/beam/pull/24784#discussion_r1057899580
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BeamRowToStorageApiProtoTest.java:
##########
@@ -392,4 +415,11 @@ public void testMessageFromTableRow() throws Exception {
DynamicMessage nestedMsg = (DynamicMessage)
msg.getField(fieldDescriptors.get("nested"));
assertBaseRecord(nestedMsg);
}
+
+ @Test
Review Comment:
Ahh yes, I wrote that dummy test just to confirm that the system UTC clock
on the Jenkins machine was in fact using millis precision.
I logged the output of `Instant.now()` (see
[here](https://ci-beam.apache.org/job/beam_PreCommit_Java_GCP_IO_Direct_Commit/1193/testReport/org.apache.beam.sdk.io.gcp.bigquery/BeamRowToStorageApiProtoTest/testInstant/))
and got `2022-12-27T19:32:26.036Z`
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BeamRowToStorageApiProtoTest.java:
##########
@@ -392,4 +415,11 @@ public void testMessageFromTableRow() throws Exception {
DynamicMessage nestedMsg = (DynamicMessage)
msg.getField(fieldDescriptors.get("nested"));
assertBaseRecord(nestedMsg);
}
+
+ @Test
Review Comment:
will remove the test now!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
