reuvenlax commented on code in PR #24145:
URL: https://github.com/apache/beam/pull/24145#discussion_r1067606696
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/SplittingIterable.java:
##########
@@ -17,23 +17,50 @@
*/
package org.apache.beam.sdk.io.gcp.bigquery;
+import com.google.api.services.bigquery.model.TableRow;
import com.google.cloud.bigquery.storage.v1.ProtoRows;
import com.google.protobuf.ByteString;
import java.util.Iterator;
import java.util.NoSuchElementException;
+import java.util.function.BiConsumer;
+import java.util.function.Function;
+import javax.annotation.Nullable;
/**
* Takes in an iterable and batches the results into multiple ProtoRows
objects. The splitSize
* parameter controls how many rows are batched into a single ProtoRows object
before we move on to
* the next one.
*/
class SplittingIterable implements Iterable<ProtoRows> {
+ interface ConvertUnknownFields {
Review Comment:
This is a Java functional interface - any matching lambda will conform. e.g.
you can pass in (tableRow, ignore) -> {} and this will conform to the interface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
